Consolidate 15 open PRs: dependency updates, GitHub Actions upgrades, Phase 4 documentation, and CI/CD fixes#43
Conversation
Co-authored-by: doublegate <6858123+doublegate@users.noreply.github.com>
Co-authored-by: doublegate <6858123+doublegate@users.noreply.github.com>
doublegate
left a comment
There was a problem hiding this comment.
Reviewed / Approved - x13 File Changes for Squash and Merge to 'main' Branch -- DG 12/10
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Upload build artifacts for other jobs to use | ||
| - name: Upload build artifacts | ||
| uses: actions/upload-artifact@v4 | ||
| uses: actions/upload-artifact@v5 | ||
| with: | ||
| name: build-artifacts-${{ runner.os }} |
There was a problem hiding this comment.
Use published upload-artifact action version
The master pipeline now references actions/upload-artifact@v5, but the upstream action is only published up to v4; GitHub fails the step with “Unable to resolve action actions/upload-artifact@v5” before any artifacts are uploaded, which blocks downstream jobs that expect those build artifacts. The previous config used v4 (valid), so this change introduces a CI break across builds triggered by this workflow (and similarly updated workflows).
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
This PR consolidates 15 open pull requests into a comprehensive update covering dependency upgrades, CI/CD modernization, and complete Phase 4 Scripting documentation. The changes introduce production-ready Lua scripting with 50+ IRC API functions, update critical dependencies for security and performance, and upgrade GitHub Actions workflows to modern runtimes.
Key changes include:
- Phase 4 Scripting Complete: Full Lua 5.4 integration with comprehensive API, event system, and 4 built-in example scripts
- Security & Performance Updates: Critical dependency updates including rustls 0.23.35, tokio 1.48.0, regex 1.12.2, and thiserror 2.0.17
- CI/CD Modernization: GitHub Actions upgraded to Node.js 24 runtime (checkout v6, upload-artifact v5, download-artifact v6)
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/url_logger.lua | New 217-line example script demonstrating URL detection, logging, and search with configurable buffer |
| scripts/README.md | Comprehensive 742-line scripting guide with complete API reference, tutorials, and security documentation |
| CHANGELOG.md | Detailed v0.4.0 release notes documenting 50+ Lua IRC API functions, event system, and built-in scripts |
| README.md | Version update to 0.4.0, test count adjustment to 62 (lib/bins only), Phase 4 completion badges, and scripting highlights |
| CONTRIBUTING.md | Added Lua scripting contribution guidelines and updated test commands to exclude doctests |
| Cargo.toml | Workspace dependency updates: tokio 1.48.0, regex 1.12.2, tracing-subscriber 0.3.20, proptest 1.9.0 |
| Cargo.lock | Comprehensive lockfile updates reflecting all dependency version changes with transitive dependencies |
| prototypes/scripting-lua/Cargo.toml | tracing-subscriber version pinned to 0.3.20 for consistency |
| prototypes/network-tokio/Cargo.toml | tracing-subscriber version pinned to 0.3.20 for consistency |
| .github/workflows/ci.yml | actions/checkout v5→v6, actions/download-artifact v5→v6 upgrades |
| .github/workflows/release.yml | actions/checkout v5→v6, actions/upload-artifact v4→v5, actions/download-artifact v5→v6 upgrades |
| .github/workflows/master-pipeline.yml | actions/checkout v5→v6, actions/upload-artifact v4→v5, actions/download-artifact v5→v6 upgrades |
| .github/workflows/security-audit.yml | actions/checkout v5→v6, actions/upload-artifact v4→v5 upgrades |
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on January 14
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
@copilot apply changes based on the comments in this thread |
Co-authored-by: parobek <parobek@gmail.com>
|
Cursor Agent can help with this pull request. Just |
doublegate
left a comment
There was a problem hiding this comment.
Reviewed / Approved -- DG 12/10
…endencies Co-authored-by: doublegate <6858123+doublegate@users.noreply.github.com>
doublegate
left a comment
There was a problem hiding this comment.
[Final] Reviewed / Approved - x13 File Changes, as per PR Combination -- DG 12/10
|
@copilot Fix the issues (ALL errors/warnings) in a new sub-PR, in the four failed checks that were just run, until everything is resolved and complete |
Co-authored-by: doublegate <6858123+doublegate@users.noreply.github.com>
Fixed in commit a3884c5. Resolved all CI/CD failures: Issues Fixed:
The failing checks were:
All configuration issues have been resolved and the workflows should now pass. |
doublegate
left a comment
There was a problem hiding this comment.
Approved x2 File Modifications - Fix Failing Checks in PR -- DG 12/11
Pull Request
Description
Combines 15 open pull requests into a single consolidated update covering dependency upgrades, CI/CD modernization, Phase 4 Scripting documentation, and workflow configuration fixes.
Related Issue
Addresses repository maintenance by consolidating all pending PRs.
Type of Change
Changes Made
Dependabot Dependency Updates (9 PRs)
GitHub Actions Upgrades (3 PRs)
Phase 4 Documentation (3 PRs)
--workspace --lib --binsCode Quality Improvements
CI/CD Configuration Fixes
allow-dependencies-licensesanddeny-packages(changed from objects withpackage-namekeys to simple string arrays)allow-ghsasfromnullto empty array[]continue-on-errorfor PR comment posting to prevent failures when called fromworkflow_callwithout proper permissionsTesting
Test Details
cargo build- 0 errors, all 6 crates compile successfullycargo test --workspace --lib --bins- 56 tests passing (10 core, 7 gui, 4 plugins, 26 protocol, 5 scripting, 4 tui)cargo clippy -- -D warnings- 0 warningscargo updatewith no conflictsScreenshots (if applicable)
N/A - Infrastructure, documentation, and CI/CD configuration changes only.
Performance Impact
Minor performance improvements expected from dependency updates (regex optimization, tokio async runtime improvements).
Security Considerations
Security improvements include rustls TLS updates, input validation enhancements in newer dependency versions, documented sandboxing model for Lua scripting (removes os.execute, io.*, require), and fixed CI/CD security audit workflow configuration.
Breaking Changes
Checklist
Impact Summary
Files Modified: 15 (+1,340/-270 lines net)
Consolidation Benefit: Single review cycle instead of 15 separate PRs, unified dependency snapshot, complete Phase 4 documentation in one atomic update, and resolved CI/CD configuration issues.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Note
Modernizes CI actions and dependencies, and adds comprehensive Phase 4 Lua scripting docs plus a new URL logger script.
--workspace --lib --bins).scripts/README.md(full Lua scripting guide) and examplescripts/url_logger.lua.actions/checkouttov6,actions/upload-artifacttov5, andactions/download-artifacttov6acrossci.yml,master-pipeline.yml,release.yml, andsecurity-audit.yml.tokio1.48,regex1.12,proptest1.9,tracing-subscriber0.3.20.mlua 0.11.5,rustls 0.23.35,serde_json 1.0.145,tracing 0.1.43,webpki-roots 1.0.4, and related updates.Written by Cursor Bugbot for commit 3a8f275. This will update automatically on new commits. Configure here.